-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add ALTER TABLE SET #3485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @VaggelisD 👍
georgesittas
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok couple more comments, LGTM otherwise
georgesittas
approved these changes
May 17, 2024
VaggelisD
force-pushed
the
vaggelisd/alter_set
branch
from
May 17, 2024 17:52
4f8c861
to
2b8095d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for
ALTER TABLE ... SET ...
across first class dialects.Design notes:
exp.AlterSet
node belonging inALTER_PARSERS
that will hold the arguments across all mentioned dialectsexp.DataDeletionProperty
to parse T-SQL'sDATA_DELETION
argumentexp.WithSystemVersioningProperty
andexp.SerdeProperties
to optionally include theWITH
keyword as a boolean argparse_properties
as a catch-all since many options are parsed as such already & to parse simple statements likeALTER TABLE ... SET <opt> = <val>
as "anonymous"exp.Property
which solves the need of more manual parsingDocs
T-SQL | Postgres | Spark | Hive | Databricks | Snowflake | Redshift | BigQuery