Added support for 16 bit bus for I2CMasterBus #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandruradovici
requested changes
Jan 23, 2024
| @@ -301,7 +301,21 @@ impl<'a, I: I2CDevice> Bus<'a> for I2CMasterBus<'a, I> { | |||
| } | |||
| } | |||
| }), | |||
|
|
|||
| BusWidth::Bits16LE => self | |||
There was a problem hiding this comment.
Can we add all the variants here? The code should be straight forward.
5 tasks
bradjc
reviewed
Jan 23, 2024
Comment on lines
+308
to
+309
| buffer[0] = 0x00; | ||
| buffer[1] = addr as u8; |
There was a problem hiding this comment.
If addr_width is 16, couldn't addr be 16 bits?
alexandruradovici
requested changes
Jan 23, 2024
| .addr_buffer | ||
| .take() | ||
| .map_or(Err(ErrorCode::NOMEM), |buffer| { | ||
| buffer[0] = 0x00; |
There was a problem hiding this comment.
Suggested change
| buffer[0] = 0x00; | |
| buffer[0] = addr & 0xff; |
| .take() | ||
| .map_or(Err(ErrorCode::NOMEM), |buffer| { | ||
| buffer[0] = 0x00; | ||
| buffer[1] = addr as u8; |
There was a problem hiding this comment.
Suggested change
| buffer[1] = addr as u8; | |
| buffer[1] = (addr >> 8) as u8; |
|
Why add this if it's untested? If it is not being used we don't need to support it |
This is used and @alexandruradovici explicitly asked for it to be split out in #3811. @Cristian243342 Do you have any updates on this? |
|
@alexandruradovici, do you know how to best proceed here? |
|
This is not yet done, I'll talk to my student and get back on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds support for 16 bit bus for I2CMasterBus.
Testing Strategy
This pull request is untested.
TODO or Help Wanted
This pull request still needs testing.
Documentation Updated
Formatting
make prepush.