Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): wrong usage of optl #6714

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Apr 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 30.50847% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 66.90%. Comparing base (ec73f69) to head (cf5045d).
Report is 3 commits behind head on canary.

Files Patch % Lines
...d/server/src/fundamentals/metrics/opentelemetry.ts 24.41% 65 Missing ⚠️
...erver/src/fundamentals/metrics/instrumentations.ts 46.87% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6714      +/-   ##
==========================================
- Coverage   67.06%   66.90%   -0.16%     
==========================================
  Files         580      581       +1     
  Lines       27191    27265      +74     
  Branches     2513     2512       -1     
==========================================
+ Hits        18236    18243       +7     
- Misses       8687     8754      +67     
  Partials      268      268              
Flag Coverage Δ
server-test 77.34% <30.50%> (-0.26%) ⬇️
unittest 40.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo marked this pull request as draft April 29, 2024 03:18
@forehalo forehalo force-pushed the 61/fix-tracing-and-metrics branch 3 times, most recently from e1a52b5 to e76782f Compare May 6, 2024 06:53
@forehalo forehalo force-pushed the 61/fix-tracing-and-metrics branch from e76782f to 6f6a1e9 Compare May 6, 2024 07:30
@github-actions github-actions bot added the test Related to test cases label May 6, 2024
@forehalo forehalo force-pushed the 61/fix-tracing-and-metrics branch from 6f6a1e9 to cf5045d Compare May 6, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant