Add a deno pet #567
Open
Add a deno pet #567
+88
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Erm. This is amazing. Well done on the PR. I'll take some time to try this out with a few different scenarios then give a +1 |
tonybaloney
reviewed
Jun 3, 2024
| @@ -178,6 +179,8 @@ export function createPet( | |||
| return new Cat(...standardPetArguments, PetSpeed.normal); | |||
| case PetType.chicken: | |||
| return new Chicken(...standardPetArguments, PetSpeed.normal); | |||
| case PetType.deno: | |||
| return new Deno(...standardPetArguments, PetSpeed.normal); | |||
There was a problem hiding this comment.
I've been playing around with a couple of these and think the pet animations might look more natural at slow instead of normal. It would walk and run slower (fewer pixels/sec), but it is a big ol' dinosaur.
What do you think?
There was a problem hiding this comment.
awww yeah, could be kind of cute lumbering around
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 16.80% 17.07% +0.26%
==========================================
Files 22 23 +1
Lines 1166 1177 +11
Branches 158 158
==========================================
+ Hits 196 201 +5
- Misses 964 970 +6
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a lil dinosaur pet to represent Deno.