Allow subclasses to manipulate reachabilityFlags #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, many methods made a direct call to SCNetworkReachabilityGetFlags(reachabilityRef, &flags) to get the flags. Since we already have a method that does this, we can "program to an interface" and have all flag queries go through `-reachabilityFlags` to gain readability (IMO) and more importantly the ability of subclasses overriding `-reachabilityFlags` for testing purposes.
|
Yes that seems reasonable & understandable. Let me look it over and I'll try merging. |
|
The problem with using the I've seen cases where this doesn't happen, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, many methods made a direct call to
SCNetworkReachabilityGetFlags(reachabilityRef, &flags)to get the flags. Since we already have a method that does this, we can "program to an interface" and have all flag queries go through-reachabilityFlagsto gain readability (IMO) and more importantly the ability of subclasses overriding-reachabilityFlagsfor automated testing purposes.Note that I did this in the github file editor to see if there's any interest. If you like the general idea, let me know and I'll do more extensive testing.
If you really like the idea, it would be extra-cool to have Reachability have flag manipulation built into reachability instances, or perhaps provide an official category extension to enable it.
Is my use case clear?