Update events forwarder cache to run cleanup manually when cache expires

[wl-yankabuki]

Relates to the following issue: patrickmn/go-cache#141

Description
The caching dependency is not running the cleanup properly due to how the cache is implemented in the events forwarder client.

The cache implementation only runs calls OnEvict each cleanupInterval, for each cache item that is expired. Whenever we try to use a cached connection that is expired, we create a new connection, which in turn uses a new expiration date.

If we try to access a cached connection that is expired but not properly evicted, we will end up replacing it before calling the close() procedure and we will end up with opened grpc connections.

---

The pipeline change is necessary due to Github updating its ubuntu-latest image to Ubuntu 22.04 and Ubuntu 22.04 not being supported by K3s

[codecov-commenter]

Codecov Report

Merging #549 (bbcbb1b) into main (ada676e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   83.79%   83.75%   -0.04%     
==========================================
  Files          84       84              
  Lines        5368     5369       +1     
==========================================
- Hits         4498     4497       -1     
- Misses        708      709       +1     
- Partials      162      163       +1     

Impacted Files	Coverage Δ
internal/adapters/events/forwarder_client.go	65.43% <100.00%> (+0.43%)	⬆️
...l/adapters/runtime/kubernetes/game_room_watcher.go	75.17% <0.00%> (-1.42%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[tobiasbu]

LGTM!

[manuellysuzik]

LGTM!

[henrod]

Not sure I got it. Aren't the clients being closed in the OnEvict method? How are the connections being kept open?

[wl-yankabuki]

Not sure I got it. Aren't the clients being closed in the OnEvict method? How are the connections being kept open?

The OnEvict is not guaranteed to run for all cache items. The execution of this function only happens in the cleanup ticket that runs in a goroutine. If you replace the cache item after its expiration, but before the goroutine execution, the onEvict is never called, since the map item is replaced with the new one with a different expiration time.

[henrod]

Nice, got it! Thanks!

[henrod]

LGTM