fix(xforwarder): Set the remote proxy's IP to the HTTP request context when PROXY Protocol is enabled #10492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsarr
changed the title
mmatur
added
status/2-needs-review
kind/bug/fix
andsarr
commented
Mar 9, 2024
2 tasks
…XY Protocol is enabled
andsarr
force-pushed
the
fix/proxy_protocol_headers
branch
from
3d3769f
to
177bbbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the PROXY Protocol is enabled, and the PROXY Header is sent, the XForwarded only sees the remote address contained on the PROXY Header since the
go-proxyproto.Listenerhas already modified the connection (technically it just wraps it) in the TCP layer.This means, that the
XForwardedcannot determined if the remote proxy (the server connection to Traefik) is allowed to forward headers.This PR makes the
XForwardedaware of the PROXY Protocol. When a new HTTP connection is established, the IP of the proxy is added to the request context.Motivation
Fixes 9757
More
Additional Notes