Fix rule syntax version for all internal routers #10689
Merged
+60
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
kind/bug/fix
2 tasks
HalloTschuess
force-pushed
the
set-rule-syntax-explicitly
branch
from
8108e61
to
5027714
Compare
HalloTschuess
changed the title
|
I previously added explicit But as it turns out this would probably break the "workaround" for #10672. Therefore I reverted this change for now and only fixed the redirection. The problem I tried to fix there was that |
HalloTschuess
force-pushed
the
set-rule-syntax-explicitly
branch
from
5027714
to
19bad2b
Compare
HalloTschuess
changed the title
HalloTschuess
force-pushed
the
set-rule-syntax-explicitly
branch
from
19bad2b
to
f9fd3d1
Compare
HalloTschuess
force-pushed
the
set-rule-syntax-explicitly
branch
from
f9fd3d1
to
26b85bd
Compare
|
You don't need to rebase, our bot will handle the rebase when the PR has 3 approvals. |
Co-authored-by: romain <rtribotte@users.noreply.github.com>
traefiker
force-pushed
the
set-rule-syntax-explicitly
branch
from
26b85bd
to
0a75545
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the rule syntax to
v3explicitly fordynamic.Routerinitialization for all internal routes.Motivation
Fixes #10688