Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/core: add type tests #5153

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

@uppy/core: add type tests #5153

wants to merge 2 commits into from
+51 −0

Conversation

Murderlon
Copy link
Member

Ref: #4764

Some tests to make sure types keep working as expected.

@Murderlon Murderlon requested a review from aduh95 May 8, 2024 11:19
@Murderlon Murderlon self-assigned this May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Diff output files 
No diff

aduh95
aduh95 approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add test cases with type errors, to validates that errors would be reported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

@Murderlon Murderlon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Murderlon @aduh95