Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onInputValueChange #733

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lary15
Copy link

@Lary15 Lary15 commented Oct 7, 2023

Description
This PR adds onInputValueChange prop to the SearchSelect and MultiSelect component. This is a direct reproduction of #470 PR that is compatible to tremor v3

Related issue(s)
#444

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

With component story examples that demonstrate the intended behavior.
To see it in action, run npm run storybook and go to InputElements > SearchSelect > With On Input Value Change and
InputElements > MultiSelect> With On Input Value Change.

Screenshots (if appropriate):
image

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Add this prop to select components with search input
to retrieve entered text
@Lary15 Lary15 changed the title Feat/oninputvaluechange onInputValueChange Oct 7, 2023
@Lary15 Lary15 changed the title onInputValueChange feat: onInputValueChange Oct 7, 2023
@severinlandolt severinlandolt self-assigned this Oct 12, 2023
@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Oct 12, 2023
@severinlandolt
Copy link
Member

cf #470

@severinlandolt
Copy link
Member

Hey @Lary15 , I have this PR in mind, there will be more confilcts after the next version (3.10) for this PR, so we should park it until November. Will get back to it, thanks!

@severinlandolt severinlandolt removed the PR: In Review This PR is in the process of being reviewed by the team label Oct 18, 2023
@kldzj
Copy link

kldzj commented Dec 11, 2023

@severinlandolt did you get a chance to look at this? If this has a chance to get merged soon but the conflicts are an issue I'd be happy to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants