Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NumberInput support long presses #735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JonZhang3
Copy link

Description
The NumberInput component can be stepped up or down by long-pressing the Plus/Minus buttons.

Related issue(s)
#734

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@JonZhang3 JonZhang3 changed the title [Feature]: NumberInput support long presses feat: NumberInput support long presses Oct 8, 2023
@severinlandolt severinlandolt self-assigned this Oct 12, 2023
@severinlandolt severinlandolt added the PR: Under Consideration Has potentially wider implications which are being discussed label Oct 12, 2023
@severinlandolt severinlandolt removed the PR: Under Consideration Has potentially wider implications which are being discussed label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants