Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnItems are now virtualized #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matt-aitken
Copy link
Member

Only the Column View items on screen get rendered, using react-virtual.

This doesn't fix all the issues with very large JSON files, though it is a step in the right direction.

Related to issues #42 #18.

Remaining issues, to be fixed in a separate branch after this is merged:

Locally I'm getting RangeError: Maximum call stack size exceeded errors for very large files. I've found two separate causes for this:

  1. Getting related paths, i.e. the getRelatedPathsAtPath function. Example: https://jsonplaceholder.typicode.com/photos
  2. Inferring the types. Example from @ubuntudroid above: https://raw.githubusercontent.com/kareltucek/firmware/master/examples/mirroring_keymap.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant