New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vercel webhooks integration #706
Open
hmacr
wants to merge
17
commits into
triggerdotdev:main
Choose a base branch
from
hmacr:integrations/vercel
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d9967e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Implementation of #421
✅ Checklist
Testing
I executed the test job to verify the webhook events.
Changelog
Notes
Of the Vercel webhook events, this PR has support for all the
project
anddeployment
(exceptdeployment.ready
) events.The remaining events are configured at an
Integration
level (what Vercel provides as OAuth) and hence cannot be configured with the create-webhook API for each request separately. These events need to be configured when theIntegration
is created on the Vercel platform, so there can be only one Webhook URL set at the top level for these events. This also means OAuth cannot be configured per each user on thetrigger.dev
server.To verify the Vercel
Integration
workflow, I created a testIntegration
(trigger-dev-hmacr-test). I then configured an endpoint as theIntegration
webhook-url which received the webhook events from the teams/projects where theIntegration
was installed.If we need to support OAuth (and the
Integration
level webhook events), the path forward isIntegration
level webhook events.I've also opened a discussion to find information about refreshing the OAuth access token: Refresh Token for Integration
💯