Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing typo in Big Query Connector docs - "bigquery.view-materialization-with-filter" #21983

Merged
merged 1 commit into from
May 15, 2024

Conversation

juancgvazquez
Copy link
Contributor

Description

There's a minor typo in the parameter for Big query connector, I just found it because I had to use it.
It's simply missing a "." between bigquery and view. in the bigquery.view-materialization-with-filter.

Additional context and related issues

The right parameter can be seen here https://github.com/trinodb/trino/blob/master/plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryConfig.java#L166

Release notes

(X ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link

cla-bot bot commented May 15, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label May 15, 2024
@ebyhr ebyhr merged commit e72bf67 into trinodb:master May 15, 2024
8 of 9 checks passed
@github-actions github-actions bot added this to the 448 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants