Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating labels: Fix max-width and background-color #39720

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 29, 2024

Description

Add a max-width to label inside Floating labels. Reverting and upgrading a change inside #38313.

Motivation & Context

Issue described in #39080.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39080.
Might supersede #39480.

@louismaximepiton louismaximepiton changed the title Floating labels: Fix max-width Floating labels: Fix max-width and background-color Feb 29, 2024
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@julien-deramond julien-deramond self-requested a review June 5, 2024 14:11
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @louismaximepiton for this fix that LGTM!

I've added in this PR a new visual test because it's always challenging to gather all the different use cases along the way: 8a38e2b. We'll be able to add some other use cases if we can find other issues in the future :)

Locally:

npm run dist
# Then navigate to `file:///Users/xxxxx/twbs/bootstrap/js/tests/visual/floating-label.html`

Please note that it would be probably better at some point to do that with Storybook.

Based on these examples, the only minor improvement could be related to the following, where there's a small overlap between the long label and the invalid icon. But this could be tackled in another PR IMO:
Screenshot 2024-06-05 at 16 12 51

@mdo, are you OK with this approach? If so, I'll merge it as is for a v5.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On form floating inputs, the labels are not truncated anymore but they go outside the input box instead
3 participants