-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add links to Links field (#5223)
Closes #5115, Closes #5116 <img width="242" alt="image" src="https://github.com/twentyhq/twenty/assets/3098428/ab78495a-4216-4243-8de3-53720818a09b"> --------- Co-authored-by: Jérémy Magrin <jeremy.magrin@gmail.com>
- Loading branch information
1 parent
8074aae
commit b0d1cc9
Showing
12 changed files
with
301 additions
and
141 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200 changes: 122 additions & 78 deletions
200
...nt/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,99 +1,143 @@ | ||
| import { useMemo, useRef, useState } from 'react'; | ||
| import styled from '@emotion/styled'; | ||
| import { Key } from 'ts-key-enum'; | ||
| import { IconPlus } from 'twenty-ui'; | ||
|
|
||
| import { useLinksField } from '@/object-record/record-field/meta-types/hooks/useLinksField'; | ||
| import { FieldInputOverlay } from '@/ui/field/input/components/FieldInputOverlay'; | ||
| import { TextInput } from '@/ui/field/input/components/TextInput'; | ||
| import { FieldInputEvent } from '@/object-record/record-field/types/FieldInputEvent'; | ||
| import { LinkDisplay } from '@/ui/field/display/components/LinkDisplay'; | ||
| import { LightIconButton } from '@/ui/input/button/components/LightIconButton'; | ||
| import { DropdownMenu } from '@/ui/layout/dropdown/components/DropdownMenu'; | ||
| import { DropdownMenuInput } from '@/ui/layout/dropdown/components/DropdownMenuInput'; | ||
| import { DropdownMenuItemsContainer } from '@/ui/layout/dropdown/components/DropdownMenuItemsContainer'; | ||
| import { DropdownMenuSeparator } from '@/ui/layout/dropdown/components/DropdownMenuSeparator'; | ||
| import { MenuItem } from '@/ui/navigation/menu-item/components/MenuItem'; | ||
| import { useScopedHotkeys } from '@/ui/utilities/hotkey/hooks/useScopedHotkeys'; | ||
| import { useListenClickOutside } from '@/ui/utilities/pointer-event/hooks/useListenClickOutside'; | ||
| import { isDefined } from '~/utils/isDefined'; | ||
|
|
||
| import { FieldInputEvent } from './DateTimeFieldInput'; | ||
| const StyledDropdownMenu = styled(DropdownMenu)` | ||
| left: -1px; | ||
| position: absolute; | ||
| top: -1px; | ||
| `; | ||
|
|
||
| export type LinksFieldInputProps = { | ||
| onClickOutside?: FieldInputEvent; | ||
| onEnter?: FieldInputEvent; | ||
| onEscape?: FieldInputEvent; | ||
| onTab?: FieldInputEvent; | ||
| onShiftTab?: FieldInputEvent; | ||
| onCancel?: () => void; | ||
| onSubmit?: FieldInputEvent; | ||
| }; | ||
|
|
||
| export const LinksFieldInput = ({ | ||
| onEnter, | ||
| onEscape, | ||
| onClickOutside, | ||
| onTab, | ||
| onShiftTab, | ||
| onCancel, | ||
| onSubmit, | ||
| }: LinksFieldInputProps) => { | ||
| const { draftValue, setDraftValue, hotkeyScope, persistLinksField } = | ||
| useLinksField(); | ||
| const { persistLinksField, hotkeyScope, fieldValue } = useLinksField(); | ||
|
|
||
| const handleEnter = (url: string) => { | ||
| onEnter?.(() => | ||
| persistLinksField({ | ||
| primaryLinkUrl: url, | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| }), | ||
| ); | ||
| }; | ||
| const containerRef = useRef<HTMLDivElement>(null); | ||
|
|
||
| const handleEscape = (url: string) => { | ||
| onEscape?.(() => | ||
| persistLinksField({ | ||
| primaryLinkUrl: url, | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| }), | ||
| ); | ||
| }; | ||
| const links = useMemo( | ||
| () => | ||
| [ | ||
| fieldValue.primaryLinkUrl | ||
| ? { | ||
| url: fieldValue.primaryLinkUrl, | ||
| label: fieldValue.primaryLinkLabel, | ||
| } | ||
| : null, | ||
| ...(fieldValue.secondaryLinks ?? []), | ||
| ].filter(isDefined), | ||
| [ | ||
| fieldValue.primaryLinkLabel, | ||
| fieldValue.primaryLinkUrl, | ||
| fieldValue.secondaryLinks, | ||
| ], | ||
| ); | ||
|
|
||
| const handleClickOutside = (event: MouseEvent | TouchEvent, url: string) => { | ||
| onClickOutside?.(() => | ||
| persistLinksField({ | ||
| primaryLinkUrl: url, | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| }), | ||
| ); | ||
| }; | ||
| useListenClickOutside({ | ||
| refs: [containerRef], | ||
| callback: (event) => { | ||
| event.stopImmediatePropagation(); | ||
|
|
||
| const handleTab = (url: string) => { | ||
| onTab?.(() => | ||
| persistLinksField({ | ||
| primaryLinkUrl: url, | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| }), | ||
| ); | ||
| }; | ||
| const isTargetInput = | ||
| event.target instanceof HTMLInputElement && | ||
| event.target.tagName === 'INPUT'; | ||
|
|
||
| if (!isTargetInput) { | ||
| onCancel?.(); | ||
| } | ||
| }, | ||
| }); | ||
|
|
||
| const [isInputDisplayed, setIsInputDisplayed] = useState(false); | ||
| const [inputValue, setInputValue] = useState(''); | ||
|
|
||
| useScopedHotkeys(Key.Escape, onCancel ?? (() => {}), hotkeyScope); | ||
|
|
||
| const handleShiftTab = (url: string) => { | ||
| onShiftTab?.(() => | ||
| const handleSubmit = () => { | ||
| if (!inputValue) return; | ||
|
|
||
| setIsInputDisplayed(false); | ||
| setInputValue(''); | ||
|
|
||
| if (!links.length) { | ||
| onSubmit?.(() => | ||
| persistLinksField({ | ||
| primaryLinkUrl: inputValue, | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| }), | ||
| ); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| onSubmit?.(() => | ||
| persistLinksField({ | ||
| primaryLinkUrl: url, | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| ...fieldValue, | ||
| secondaryLinks: [ | ||
| ...(fieldValue.secondaryLinks ?? []), | ||
| { label: '', url: inputValue }, | ||
| ], | ||
| }), | ||
| ); | ||
| }; | ||
|
|
||
| const handleChange = (url: string) => { | ||
| setDraftValue({ | ||
| primaryLinkUrl: url, | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| }); | ||
| }; | ||
|
|
||
| return ( | ||
| <FieldInputOverlay> | ||
| <TextInput | ||
| value={draftValue?.primaryLinkUrl ?? ''} | ||
| autoFocus | ||
| placeholder="Links" | ||
| hotkeyScope={hotkeyScope} | ||
| onClickOutside={handleClickOutside} | ||
| onEnter={handleEnter} | ||
| onEscape={handleEscape} | ||
| onTab={handleTab} | ||
| onShiftTab={handleShiftTab} | ||
| onChange={handleChange} | ||
| /> | ||
| </FieldInputOverlay> | ||
| <StyledDropdownMenu ref={containerRef} width={200}> | ||
| {!!links.length && ( | ||
| <> | ||
| <DropdownMenuItemsContainer> | ||
| {links.map(({ label, url }, index) => ( | ||
| <MenuItem | ||
| key={index} | ||
| text={<LinkDisplay value={{ label, url }} />} | ||
| /> | ||
| ))} | ||
| </DropdownMenuItemsContainer> | ||
| <DropdownMenuSeparator /> | ||
| </> | ||
| )} | ||
| {isInputDisplayed ? ( | ||
| <DropdownMenuInput | ||
| autoFocus | ||
| placeholder="URL" | ||
| value={inputValue} | ||
| hotkeyScope={hotkeyScope} | ||
| onChange={(event) => setInputValue(event.target.value)} | ||
| onEnter={handleSubmit} | ||
| rightComponent={ | ||
| <LightIconButton Icon={IconPlus} onClick={handleSubmit} /> | ||
| } | ||
| /> | ||
| ) : ( | ||
| <DropdownMenuItemsContainer> | ||
| <MenuItem | ||
| onClick={() => setIsInputDisplayed(true)} | ||
| LeftIcon={IconPlus} | ||
| text="Add link" | ||
| /> | ||
| </DropdownMenuItemsContainer> | ||
| )} | ||
| </StyledDropdownMenu> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.