Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "test" db provisioning #3914

Closed
wants to merge 4 commits into from
Closed

Fix "test" db provisioning #3914

wants to merge 4 commits into from

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Feb 12, 2024

Description

We used to have a "test" database and some script to provision it. It's not working anymore since 0.2 though.

Refs

#3862

Demo

Screenshot 2024-02-12 at 13 21 05 Screenshot 2024-02-12 at 13 21 18 Screenshot 2024-02-12 at 13 21 26

Fixes #3862

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
@gitstart-twenty gitstart-twenty changed the title TWNTY-3862 - Fix "test" db provisioning Fix "test" db provisioning Feb 12, 2024
@gitstart-twenty
Copy link
Contributor

gitstart-twenty commented Feb 12, 2024

Hello @charlesBochet,

I initially focused on getting the tests to run smoothly. Unfortunately, the generated GraphQL schemas had duplicate types, leading to test failures. Disabling automatic schema generation and manually providing a schema resolved the issue. However, I foresee potential drawbacks with this approach, particularly the need to update the schema file whenever there are changes to the schema.

What are your thoughts at first glance?

@lucasbordeau
Copy link
Contributor

@charlesBochet I've merged with main and recent changes, we should be able to find a way to generate a test schema as we do with pre-sign-in on the frontend ?

@charlesBochet
Copy link
Member

Yes, we should tackle this one this week, I think we have all the pieces now

@gitstart-twenty
Copy link
Contributor

Yes, we should tackle this one this week, I think we have all the pieces now

Alright, Looking forward to it!

@Weiko
Copy link
Member

Weiko commented May 15, 2024

Closing this for now since this one is very old and has not been updated for a while, let's reopen when we get back to it! (cc @charlesBochet)

@Weiko Weiko closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "test" db provisioning
4 participants