Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWNTY-4313 - [ESLint plugin] Add a rule to enforce folder architecture on frontend #4427

Closed
wants to merge 2 commits into from

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Mar 12, 2024

Description

[ESLint plugin] Add a rule to enforce folder architecture on frontend

Refs

#4313

Demo

Fixes #4313

Co-authored-by: Chiazokam <chiazokamecheta@gmail.com>
@gitstart-twenty
Copy link
Contributor

Hey @charlesBochet
We found this package that can enforce project structure among other things. However, we still have some questions about the structure?

  • First, most of the code is inside the src folder, the structure specifies pages, modules and ui folders inside front. Do we get rid of src and move everything into these folders.
  • Also, the docs show an ellipsis (...), indicating the presence of other folders inside front. Well, there's a bunch of other folders inside src (I suppose we'll be keeping src), which ones stay and which ones move into other folders?
  • There's also some files directly inside the src folder, how do we handle these?

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Chiazokam <chiazokamecheta@gmail.com>
@charlesBochet
Copy link
Member

@gitstart-twenty We are almost ready for this one. We will move forward once the PR pile is lower!

@gitstart-twenty
Copy link
Contributor

@gitstart-twenty We are almost ready for this one. We will move forward once the PR pile is lower!

Thanks for the update @charlesBochet

@Weiko
Copy link
Member

Weiko commented May 15, 2024

Closing this for now since this one is very old and has not been updated for a while, let's reopen when we get back to it! (cc @charlesBochet)

@Weiko Weiko closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ESLint plugin] Add a rule to enforce folder architecture on frontend
4 participants