Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4848 - Update Checkbox component #4883

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

R894
Copy link

@R894 R894 commented Apr 8, 2024

Summary

  • Add hover state which defaults to false
  • Add disable state

chrome_KV2AltSmBK

closes #4848

Copy link

github-actions bot commented Apr 8, 2024

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against 868390f

@R894 R894 marked this pull request as draft April 8, 2024 22:54
@R894 R894 changed the title 4848 - add hover effect to checkbox component 4848 - Update Checkbox component Apr 9, 2024
@R894 R894 marked this pull request as ready for review April 9, 2024 18:37
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, looks good! I have left some comments

@R894
Copy link
Author

R894 commented Apr 11, 2024

hi @charlesBochet ,
I've added the changes you requested, I'd be happy if you could review it again

@R894 R894 requested a review from charlesBochet April 11, 2024 19:56
@charlesBochet
Copy link
Member

I'm reviewing it, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Checkbox component
2 participants