useScrollStates hook created replacing direct access to scrollTopState & scrollLeftState #4938
Conversation
There was a problem hiding this comment.
Hi @Jeetch8, thank you for your work! I have left some guidance on how to use hooks and component States. The doc is inexistant about it for now but I can guide you more if needed
| import { extractComponentState } from "@/ui/utilities/state/component-state/utils/extractComponentState" | ||
| import { ViewScopeInternalContext } from "@/views/scopes/scope-internal-context/ViewScopeInternalContext"; | ||
|
|
||
| export const useScrollStates = (scrollWrapperId?:string) => { |
There was a problem hiding this comment.
typo in the filename that should be useScrollStates
There was a problem hiding this comment.
could you move this hook into a internal subfolder within hooks. internal hooks cannot be used outside of their component (here Scroll / ScrollWrapper).
This allows us to narrow down the public API of a component to enforce interface (easy maintenance).
We will need to create another useScrollTopValue(scrollWraperId) and useScrollLeftValue(scrollWraperId) hooks. These hooks will only expose what functions we want it to expose.
Here we would for example only want to expose the getter: useRecoilValue(scrollLeftState) (scrollLeftState being imported from useScrollStates)
Then from ColumnHead, Recordtable, RecordTableHeaderCell you can use useScrollTopValue and useScrollLeftValue
|
Also, make sure to run yarn nx lint:ci twenty-front before pushing! |
|
Hey, I'm sorry I will close this since it hasn't move since the last comments a month ago. |
Hii , I have made the changes. Can you please check and give me a feedback on that ?
As I am a bit uncertain on it.
here is the issue #4826
Thank u