feat: replace iframe with chrome sidepanel #5197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaPimpalkar
commented
Apr 29, 2024
| openOptionsPage(); | ||
| } | ||
| }); | ||
| // chrome.runtime.onInstalled.addListener((details) => { |
There was a problem hiding this comment.
Commenting this for now, will replace it with a call to a dedicated page for chrome extension of twenty documentation
AdityaPimpalkar
commented
Apr 29, 2024
| <MainButton | ||
| title="Sign up" | ||
| variant="secondary" | ||
| onClick={() => window.open(`${import.meta.env.VITE_FRONT_BASE_URL}`, '_blank')} |
There was a problem hiding this comment.
Fixed the signup link
| ); | ||
| personButtonSpan.textContent = 'View in Twenty'; | ||
| personButtonDiv.onClickHandler(() => { | ||
| chrome.runtime.sendMessage({ action: 'openSidepanel' }); |
There was a problem hiding this comment.
Should change side panel url if already open ?
There was a problem hiding this comment.
Correct! I fixed it :)
| @@ -4,24 +4,31 @@ import styled from '@emotion/styled'; | |||
| import { Loader } from '@/ui/display/loader/components/Loader'; | |||
There was a problem hiding this comment.
Could we rename Options into a more self-explanatory naming ? Options seems very vague, SidePanel or something like that would be more appropriate.
…into chrome-side-panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes - #5201
Screen.Recording.2024-04-27.at.6.55.08.PM.mov