feat: twenty orm sync #5266
Merged
feat: twenty orm sync #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magrinj
force-pushed
the
feat/twenty-orm-sync
branch
from
98c3b71
to
9db2e03
Compare
Weiko
approved these changes
May 15, 2024
There was a problem hiding this comment.
Great job @magrinj! LGTM
I think we should go even further and rename CompanyObjectMetadata to CompanyWorkspaceEntity, this seems weird that it extends a BaseWorkspaceEntity now. This can be done in another PR ofc!
cc @charlesBochet for the naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is updating all object metadata entities with the new decorators, and deleting the old ones.
This way we can use the new TwentyORM with all the standard objects.