-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule-tester): stricter rule test validations #9086
base: main
Are you sure you want to change the base?
feat(rule-tester): stricter rule test validations #9086
Conversation
Thanks for the PR, @Vinccool96! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aca9d06
to
bde1e6e
Compare
Never mind, there was way less things to fix than I thought. |
901db33
to
6e71280
Compare
06d3edf
to
5f55140
Compare
@auvred Is everything good to merge? |
5f55140
to
cbdf415
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor requests but overall looks great!
Btw, there is no need to ping individuals for review. We have a queue and we get to things when we can. https://typescript-eslint.io/contributing/pull-requests
7ff0f76
to
c13178a
Compare
a2715a0
to
b121617
Compare
46a6e56
to
40ec555
Compare
…on, 'desc')) verification
40ec555
to
e761ee1
Compare
PR Checklist
Overview
Brings in changes from eslint/eslint#17654. This is pretty much a copy & paste.