fix(eslint-plugin): [prefer-literal-enum-member] allow using member it self on allowBitwiseExpressions

[yeonjuan]

PR Checklist

• Addresses an existing open issue: fixes Bug: [prefer-literal-enum-member] allowBitwiseExpressions with self-referential enums does not disable error #7763
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	3e6eb13
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6650670fbad47500084d3bfd
😎 Deploy Preview	https://deploy-preview-9114--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3e6eb13. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test typescript-eslint --coverage=false
• nx test utils --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run types:build
• nx test type-utils --coverage=false
• nx test visitor-keys --coverage=false
• nx run repo-tools:postinstall-script
• nx test typescript-estree --coverage=false
• nx test scope-manager --coverage=false
• nx test repo-tools --coverage=false
• nx test ast-spec --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test typescript-eslint
• nx test visitor-keys
• nx test scope-manager
• nx test utils
• nx test typescript-estree
• nx test type-utils
• nx test repo-tools
• nx test ast-spec
• nx test parser
• nx test rule-schema-to-typescript-types
• nx test eslint-plugin-internal
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[yeonjuan]

When the allowBitwiseExpressions option is true, an lint error is reported for the nested bitwises. I think this is a bug, and I'll open a separate issue if it's confirmed.

https://typescript-eslint.io/play/#ts=5.2.2&showAST=es&fileType=.tsx&code=KYOwrgtgBAglDeAoKsoF4oEYA0yoCF0soA%2BEqAJlxQGEiLTyAKYgPUoEpEBfIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0Wlsfy8AhvHpNYAW1oTEEgEa90YANqRe0APbRIAGkyQR8DQHcAQpXzHKyRAFEAHhxTJKGpqgz44iAL4BdcDAfEB8gA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

enum A {
  A = 1,
  B = 1 >> 2,
  C = 2 >> ( 1 ^ 2) // lint error
}

[Josh-Cena]

Have you seen this pattern in the wild?

We allow bitwise because they are "literals in effect": people read 1 << 3 as naturally as 0b1000 or 8, but the nested bitwise you have there seems like any other computation in terms of complexity.

[yeonjuan]

Hi, @Josh-Cena, When dealing with color values, it's sometimes useful to nest bitwise. But I can't think of any practical examples on the initial values of an enum. Maybe it's because I haven't used bitwise much.

const redValue = hexColor >> 16 & 0xff

Personally, I think that allowing only one bitwise operator is a bit under-supported. But I also think it's a good idea to handle it when real use cases are reported.

[yeonjuan]

@Josh-Cena oh, In the typescript repo, I found an use case of multiple bit operators in an enum initializer.

https://github.com/microsoft/TypeScript/blob/79a851426c514a12a75b342e8dd2460ee6615f73/src/harness/vpathUtil.ts#L36-L63

const enum ValidationFlags {
    None = 0,

    RequireRoot = 1 << 0,
    RequireDirname = 1 << 1,
    RequireBasename = 1 << 2,
    RequireExtname = 1 << 3,
    RequireTrailingSeparator = 1 << 4,

    AllowRoot = 1 << 5,
    AllowDirname = 1 << 6,
    AllowBasename = 1 << 7,
    AllowExtname = 1 << 8,
    AllowTrailingSeparator = 1 << 9,
    AllowNavigation = 1 << 10,
    AllowWildcard = 1 << 11,

    /** Path must be a valid directory root */
    Root = RequireRoot | AllowRoot | AllowTrailingSeparator,

    /** Path must be a absolute */
    Absolute = RequireRoot | AllowRoot | AllowDirname | AllowBasename | AllowExtname | AllowTrailingSeparator | AllowNavigation,

    /** Path may be relative or absolute */
    RelativeOrAbsolute = AllowRoot | AllowDirname | AllowBasename | AllowExtname | AllowTrailingSeparator | AllowNavigation,

    /** Path may only be a filename */
    Basename = RequireBasename | AllowExtname,
}

[JoshuaKGoldberg]

LGTM, thanks! 🚀