Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw error when range faceted field has sorting disabled #1726

Merged
merged 5 commits into from
May 15, 2024
Merged

throw error when range faceted field has sorting disabled #1726

merged 5 commits into from
May 15, 2024

Conversation

krunal1313
Copy link
Contributor

@krunal1313 krunal1313 commented May 13, 2024 •
edited

Change Summary

  • if range faceted field has sort disabled then throw error with appropriate message
  • add tests

PR Checklist

@krunal1313 krunal1313 changed the title Range facets with filtering throw error when range faceted field has sorting disabled May 14, 2024
@kishorenc kishorenc merged commit 6075362 into typesense:v27 May 15, 2024
1 check passed
kishorenc pushed a commit that referenced this pull request May 21, 2024
@krunal1313 @kishorenc
throw error when range faceted field has sorting disabled (#1726)
6e46b25 
* range facets with sort disabled

* update test names

* throw error when range faceted field has sort disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorenc kishorenc kishorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krunal1313 @kishorenc