New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WiFiManagerParameter destructor virtual #1692

Open

rguca wants to merge 1 commit into tzapu:master from rguca:wifi-param-destructor

rguca commented Dec 28, 2023

If a instance of WiFiManagerParameter is created by new and deleted by delete, a compiler warning is issued.

src/settings/SettingsController.cpp:78:67: warning: deleting object of polymorphic class type 'WiFiManagerParameter' which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
   78 |   for (WiFiManagerParameter* p : this->wifi_settings->parameters) delete p;

The destructor should be virtual, because the class can be extended.


          make WiFiManagerParameter destructor virtual

ac7c0eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment