Minor refactoring - Design level refactors #2781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2024 23:40
…d be (public) constants on their respective service classes, not here
added 5 commits
March 30, 2024 21:47
… more relevant to IUserLayoutStore. Hence moving it
…esive set of variables/constants and grouped them into their own class.
HimanshiVerma05
changed the title
added 2 commits
March 31, 2024 22:05
…hods from the PortletEventCoordinatationService into a new class named PortletEventCoordinationHelper.
…hods from the PortletEventCoordinatationService into a new class named PortletEventCoordinationHelper.
There was a problem hiding this comment.
Thanks @HimanshiVerma05!
The code looks good from reading through it.
My caution comes from this touching the PAGS and Layout subsystems, which aren't as heavily tested as I'd like while also being rather complex subsystems. Those still require some manual testing.
I've CC'ed other maintainers are reviewers to see if anyone could run some manual tests.
Some general tips:
- New tests are the quickest type of change to review
- PRs that adjust store are easier to review when they focus on one or a few subsystems, and/or a single type of refactor at a time.
- Features are also welcome, those are often mentioned/discussed on the mail list before they are added https://groups.google.com/a/apereo.org/g/uportal-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Refactored the code and worked on the comments-
"// Should refactor this switch to instead choose a service and invoke a method on it"
" // These 2 should be (public) constants on their respective service classes, not here"
in PagsService.java .