Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes: #1300 : Fix Duplicates bug in Basic-Sunburst showcase #1301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roeezolantz
Copy link

@roeezolantz roeezolantz commented Jan 9, 2020

This fixes this issue.

I've changed the recursion so each level is aware if its father was in the path, because if no - obviously, they doesn't have to be market (because even if they are contained in the path keys array, they doesn't belong to this hierarchy.)

@roeezolantz roeezolantz changed the title Fix Duplicates bug in Basic-Sunburst showcase (uber#1300) Closes: #1300 : Fix Duplicates bug in Basic-Sunburst showcase Jan 9, 2020
Changed == to ===
@CLAassistant
Copy link

CLAassistant commented Mar 13, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Roee Zolantz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicates bug in Basic-Sunburst
2 participants