Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports #1348

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix imports #1348

wants to merge 9 commits into from

Conversation

Xiot
Copy link
Contributor

@Xiot Xiot commented Jun 6, 2020

Change the import paths so they no longer look like node_module imports.
Project relative can still be done, but using the ~/ prefix.

Chris Thomas added 7 commits June 5, 2020 15:55
Change the import paths so they no longer look like node_module imports.
Project relative can still be done, but using the `~/` prefix.
Change the import paths so they no longer look like node_module imports.
Project relative can still be done, but using the `~/` prefix.
Showcase now properly references `react-vis` components.
@Xiot Xiot marked this pull request as ready for review June 6, 2020 03:22
@Xiot
Copy link
Contributor Author

Xiot commented Jun 6, 2020

Checked that react-vis builds cleanly, and that showcase and storybook both spin up.

@Xiot Xiot marked this pull request as draft June 6, 2020 03:32
@Xiot Xiot marked this pull request as ready for review June 6, 2020 03:45
@Xiot
Copy link
Contributor Author

Xiot commented Jun 7, 2020

I'll remove the codemods directory before I merge, but I left them in there for now so you can see how I changed everything.

@reitlepax
Copy link
Contributor

Nice I will take a look at the codemods!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Thomas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants