Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image download is not idempotent #911

Open
enescakir opened this issue Nov 21, 2023 · 0 comments
Open

Image download is not idempotent #911

enescakir opened this issue Nov 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@enescakir
Copy link
Member

Example:
https://github.com/ubicloud/ubicloud/actions/runs/6940687900/job/18880057225#step:7:156

The initial download of the ubuntu image failed due to OpenSSL SSL_read error: Connection reset by peer, errno 104. It appears this operation is not idempotent, as subsequent attempts also failed due to File exists @ rb_sysopen - /tmp/ubuntu-jammy.img.tmp (Errno::EEXIST)
@enescakir enescakir added the bug Something isn't working label Nov 21, 2023
@enescakir enescakir mentioned this issue Jan 23, 2024
Merged
enescakir added a commit that referenced this issue Jan 24, 2024
@enescakir
Remove tmp image if the download operation fails
85c88bf 
If the download operation fails for any reason, subsequent attempts
result in a `File exists @ rb_sysopen - /tmp/ubuntu-jammy.img.tmp
(Errno::EEXIST)` error. In case of failure, the temporary image must be
removed.

Fixes #911
@enescakir enescakir mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove tmp image if the download operation fails ubicloud/ubicloud
1 participant
@enescakir