Do not convert the image if it's already in .raw format #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdr
reviewed
Dec 30, 2023
enescakir
force-pushed
the
boot-image-raw
branch
from
7de64cf
to
e78a668
Compare
fdr
approved these changes
Jan 9, 2024
enescakir
force-pushed
the
boot-image-raw
branch
from
e78a668
to
ef46e73
Compare
enescakir
force-pushed
the
boot-image-raw
branch
from
ef46e73
to
523daf0
Compare
enescakir
force-pushed
the
boot-image-raw
branch
from
523daf0
to
08b49fb
Compare
enescakir
force-pushed
the
download-location
branch
from
c850623
to
a33c5d6
Compare
enescakir
force-pushed
the
boot-image-raw
branch
from
08b49fb
to
e4c4d0c
Compare
enescakir
force-pushed
the
download-location
branch
from
a33c5d6
to
73d4d3f
Compare
enescakir
force-pushed
the
boot-image-raw
branch
from
e4c4d0c
to
6881117
Compare
fdr
approved these changes
Feb 1, 2024
We convert 'qcow2', 'img', and 'vhd' images to 'raw' format to enable
their use with Cloud Hypervisor. If the source image is already in
'raw' format, there's no need for conversion; we simply move it.
At present, we don't have any source images in 'raw' format. However, I
plan to distribute GitHub runner images via our internal MinIO cluster.
Instead of uploading 'vhd' images, I will upload the converted 'raw'
images to MinIO. This way, each VM host won't need to convert images,
which has two main benefits:
- Converting 86GB images typically takes 6-7 minutes. Distributing
'raw' images will speed up the image download operation on VM hosts.
- When each VM host converts the image locally, the resulting raw
images are not identical, as their checksums differ. By distributing
a 'raw' image, we can ensure that all VM hosts have the exact same
image file.
enescakir
force-pushed
the
boot-image-raw
branch
from
6881117
to
a1811c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We convert 'qcow2', 'img', and 'vhd' images to 'raw' format to enable their use with Cloud Hypervisor. If the source image is already in 'raw' format, there's no need for conversion; we simply move it.
At present, we don't have any source images in 'raw' format. However, I plan to distribute GitHub runner images via our internal MinIO cluster. Instead of uploading 'vhd' images, I will upload the converted 'raw' images to MinIO. This way, each VM host won't need to convert images, which has two main benefits: