Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Firewalls assignable to multiple subnets #1456

Merged
merged 2 commits into from May 2, 2024
Merged

Make Firewalls assignable to multiple subnets #1456

merged 2 commits into from May 2, 2024

Conversation

furkansahin
Copy link
Contributor

@furkansahin furkansahin commented Apr 12, 2024 •
edited

With this commit, our backend starts supporting Firewalls <->
PrivateSubnets many_to_many relationship. For that to work, we introduce
a new model called FirewallsPrivateSubnets and maintain the relationship
properly at the de/provisioning times.

@furkansahin furkansahin force-pushed the multiple_fws_per_subn branch 2 times, most recently from 294708d to 2f1a32c Compare April 17, 2024 12:03
@furkansahin furkansahin marked this pull request as ready for review April 17, 2024 12:04
velioglu
velioglu approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@velioglu velioglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've discussed offline, creating firewalls and having an endpoint to associate it with the subnet will be added with a subsequent PR.

model/firewall.rb Show resolved Hide resolved
enescakir
enescakir reviewed May 2, 2024
View reviewed changes
model/firewall.rb Outdated Show resolved Hide resolved
model/firewall.rb Show resolved Hide resolved
model/firewalls_private_subnets.rb Show resolved Hide resolved
model/private_subnet.rb Show resolved Hide resolved
byucesoy
byucesoy reviewed May 2, 2024
View reviewed changes
model/firewall.rb Outdated Show resolved Hide resolved
@furkansahin furkansahin requested a review from enescakir May 2, 2024 13:54
Base automatically changed from fw_to_subnet to main May 2, 2024 18:04
@furkansahin
Make Firewalls assignable to multiple Subnets migration
941a34b
@furkansahin
Make Firewalls assignable to multiple Subnets
f280261 
With this commit, our backend starts supporting Firewalls <->
PrivateSubnets many_to_many relationship. For that to work, we introduce
a new model called FirewallsPrivateSubnets and maintain the relationship
properly at the de/provisioning times.
@furkansahin furkansahin merged commit 2bf033f into main May 2, 2024
6 checks passed
@furkansahin furkansahin deleted the multiple_fws_per_subn branch May 2, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fdr fdr fdr left review comments

@byucesoy byucesoy byucesoy left review comments

@enescakir enescakir enescakir approved these changes

@velioglu velioglu velioglu approved these changes

@bsatzger bsatzger Awaiting requested review from bsatzger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@furkansahin @fdr @enescakir @byucesoy @velioglu