Add Vm.update_spdk_version(...) #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
force-pushed
the
pykello/storage_upgrade_2
branch
from
8b7a669
to
ccf3b82
Compare
pykello
changed the title
pykello
force-pushed
the
pykello/storage_upgrade_2
branch
3 times, most recently
from
ee2c35b
to
ef5ee48
Compare
fdr
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
alright, though regenerating the unit file is a step into a different world just a little bit, where can't get some implied backwards compatibility anymore. We'll need to keep the re-generation in order with all extant VMs.
For example, if we move to using hotplug to set up cloud-hypervisor rather than command line options, there will be new considerations.
Not a blocker, but it's a transition.
pykello
force-pushed
the
pykello/storage_upgrade
branch
from
6ba406d
to
4be85f3
Compare
When changing the SPDK version of a VM, we need to reinstall these to update these, as VM services have dependencies to SPDK.
pykello
force-pushed
the
pykello/storage_upgrade_2
branch
from
ef5ee48
to
3943feb
Compare
pykello
force-pushed
the
pykello/storage_upgrade_2
branch
2 times, most recently
from
edd5fb3
to
b4edf29
Compare
Previously to change SPDK version of a VM we needed to do multiple
weird manual steps. This patch automates some of them and what we need
to do is:
1. Install the new SPDK version on the host:
```
> Prog::Storage::SetupSpdk.assemble(
vm_host.id, "some-spdk-version",
start_service: true, allocation_weight: 100)
```
2. Update all VMs we want to migrate to this SPDK version. Note that
this will just update related configs and won't take effect until host
reboot:
```
> vm.update_spdk_version("some-spdk-version")
```
3. Reboot host:
```
> vm_host.incr_reboot
```
4. Optionally, remove the old SPDK installation:
```
> Prog::Storage::RemoveSpdk.assemble(old_spdk_installation.id)
```
pykello
force-pushed
the
pykello/storage_upgrade_2
branch
from
b4edf29
to
22d7814
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously to change SPDK version of a VM we needed to do multiple weird manual steps. This patch automates some of them and what we need to do is: