Use Regexp literals in validations #1479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to store regular expressions as strings in the validations.rb which causes them to be compiled every time the validation is run. With this commit we are changing them to be stored as Regexp objects which are compiled only once at the load time.
|
Does this PR conflict with this commit f6b4599 |
|
It's actually based on and cherry picked :) (I even kept the author) |
|
I just figured using the appropriate ruby literal had Less Going On (escaping rules, even amount of evaluation on file load, though it's immaterial) |
byucesoy
approved these changes
Apr 19, 2024
furkansahin
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to store regular expressions as strings in the validations.rb which causes them to be compiled every time the validation is run. With this commit we are changing them to be stored as Regexp objects which are compiled only once at the load time.