US Region Prep #1503
Merged
US Region Prep #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkansahin
force-pushed
the
us_region_prep
branch
from
43cee25
to
491a4c4
Compare
fdr
approved these changes
Apr 24, 2024
enescakir
reviewed
Apr 24, 2024
|
woops shouldn't it be east?
…On Wed, Apr 24, 2024 at 4:09 PM Enes Çakır ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In config/providers.yml
<#1503 (comment)>:
> @@ -7,5 +7,12 @@
{display_name: eu-north-h1, internal_name: hetzner-hel1, visible: true },
{display_name: github-runners, internal_name: github-runners, visible: false }
]
+ },
+ {
+ provider_display_name: Leaseweb,
+ provider_internal_name: leaseweb,
+ locations: [
+ {display_name: us-central-l1, internal_name: leaseweb-wdc02, visible: true },
Why isn't it us-central-l2 instead of us-central-l1, given that it's wdc02
?
Is Washington DC more central US than east US?"
—
Reply to this email directly, view it on GitHub
<#1503 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAABYF7EQJSQSNSFA6FESILY7A3UJAVCNFSM6AAAAABGXAUSU2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRRGEYDEMBYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
furkansahin
force-pushed
the
us_region_prep
branch
from
491a4c4
to
2ca1cea
Compare
furkansahin
force-pushed
the
us_region_prep
branch
2 times, most recently
from
6a5a4b4
to
00bea9e
Compare
This package was included in Hetzner but not in Leaseweb. Therefore, we had to make this change to support the Leaseweb as a provider.
furkansahin
force-pushed
the
us_region_prep
branch
from
00bea9e
to
6e8de01
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new billing rates, provider and makes changes to dataplane to support a US region.