Download & use versioned images #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
force-pushed
the
pykello/image_versioning
branch
2 times, most recently
from
ec842b8
to
4b876e7
Compare
pykello
changed the title
pykello
force-pushed
the
pykello/image_versioning
branch
from
4b876e7
to
8d3af48
Compare
enescakir
reviewed
May 2, 2024
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
3 times, most recently
from
d54aa7a
to
cd545b0
Compare
pykello
force-pushed
the
pykello/image_versioning
branch
from
8d3af48
to
89e7fdf
Compare
pykello
force-pushed
the
pykello/image_versioning
branch
2 times, most recently
from
7808104
to
c4c45ca
Compare
enescakir
reviewed
May 8, 2024
pykello
force-pushed
the
pykello/image_versioning
branch
from
c4c45ca
to
2e1a6f1
Compare
|
adding @bsatzger for allocator changes |
enescakir
reviewed
May 8, 2024
pykello
force-pushed
the
pykello/image_versioning
branch
from
2e1a6f1
to
434929e
Compare
pykello
force-pushed
the
pykello/image_versioning
branch
from
434929e
to
5a9d7f8
Compare
bsatzger
approved these changes
May 8, 2024
pykello
changed the title
enescakir
approved these changes
May 9, 2024
pykello
force-pushed
the
pykello/image_versioning
branch
from
5a9d7f8
to
7435a7c
Compare
pykello
force-pushed
the
pykello/image_versioning
branch
from
7435a7c
to
ad4983e
Compare
Previously, we ran LearnStorage after an image was downloaded to update StorageDevice::available_storage_gib of storage devices on the host. However, this caused problems when there were existing storage volumes on the host: A storage volume's file can be sparse, in which case `df` will report a lower occupied space for it. This causes problems down the road. This PR changes that so we instead deduct the downloaded image size from available_storage_gib.
pykello
force-pushed
the
pykello/image_versioning
branch
from
ad4983e
to
ef8654f
Compare
enescakir
approved these changes
May 9, 2024
yes |
pykello
force-pushed
the
pykello/image_versioning
branch
3 times, most recently
from
c8f4f5b
to
6b43e9a
Compare
In #1524 we changed rhizome to be able to download versioned boot images. In this change, we actually use that infrastructure. To download a versioned boot image, one can do: ``` > vmh.download_boot_image("ubuntu-jammy", version: "20240319") ``` After this has been done, all VMs on that host which want to use the `ubuntu-jammy` image will use the latest boot image. This allows us to be able to download new image versions without impacting previous VMs at all. Previous VMs will continue to use the older images. As follow up items: * VmHost setup will include downloading some default images (e.g. `ubuntu-jammy`) with explicit. vm_setup won't download the images automatically. * We will enforce to use versioned images always * Add a program to remove unused images
pykello
force-pushed
the
pykello/image_versioning
branch
from
6b43e9a
to
522340d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1524 we changed rhizome to be able to download versioned boot images. In this change, we actually use that infrastructure.
To download a versioned boot image, one can do:
After this has been done, all VMs on that host which want to use the
ubuntu-jammyimage will use the latest boot image.This allows us to be able to download new image versions without impacting previous VMs at all. Previous VMs will continue to use the older images.
As follow up items:
ubuntu-jammy) with explicit. vm_setup won't download the images automatically.