Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register deadlines before hopping to the new label #750

Merged
merged 1 commit into from Oct 21, 2023
Merged

Register deadlines before hopping to the new label #750

merged 1 commit into from Oct 21, 2023

Conversation

enescakir
Copy link
Member

We have a known issue #718. If the label that we register deadline fails, we can't persist the deadline information to the strand's stack.

If destroy or start_after_host_reboot fails for some reasons, we will not get a page.

@enescakir enescakir changed the title Register deadlines before hopping the new label Register deadlines before hopping to the new label Oct 19, 2023
@enescakir enescakir self-assigned this Oct 19, 2023
fdr
fdr approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@fdr fdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the apparent test simplification. I have an idea to make this more "automatic," but I'm not sure if it's a good idea overall. Maybe isolating deadline setting should be our custom and that's fine.

@enescakir enescakir added refactor bug Something isn't working and removed refactor labels Oct 20, 2023
@enescakir
Copy link
Member Author

I like the apparent test simplification. I have an idea to make this more "automatic," but I'm not sure if it's a good idea overall. Maybe isolating deadline setting should be our custom and that's fine.

Indeed, we need to find a more elegant and automated solution. It's quite easy to make mistakes. Until then, we must be vigilant with deadline registrations.

@enescakir
Register deadlines before hopping to the new label
07a28d5 
We have a known issue #718. If the label that we register deadline
fails, we can't persist the deadline information to the strand's stack.

If destroy or start_after_host_reboot fails for some reasons, we will
not get a page.
@enescakir enescakir temporarily deployed to E2E-CI October 21, 2023 09:58 — with GitHub Actions Inactive
@enescakir enescakir merged commit 7675548 into main Oct 21, 2023
5 checks passed
@enescakir enescakir deleted the destroy-deadline branch October 21, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdr fdr fdr approved these changes

@pykello pykello Awaiting requested review from pykello

@byucesoy byucesoy Awaiting requested review from byucesoy

@furkansahin furkansahin Awaiting requested review from furkansahin

Assignees

@enescakir enescakir

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@enescakir @fdr