fix: default to rendering the editor immediately, while staying backward compatible #5161
+261
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
A third PR for performance of the useEditor hook 😅.
What I've done here is combine a few of the different approaches and added a bit of my own spin to it:
Prior art:
What I've done here is to take a spin on #4579 and base it on a
useSyncExternalStore
instead (for efficient re-rendering handled by react).While adding the performance optimization made by #4453 (re-using existing editor instances, and just updating their options if they change).
It is backward-compatible to people who use SSR (printing a warning and telling them they should set the new flag explicitly for forward-compatible but only in dev mode).
It is forward-compatible, where if you don't specify the new flag, people will automatically have the editor on first render.
If the flag is specified, you get better TS types since it is now guaranteed that you get an editor instance.
If you include the
select
function, you can effectively choose when the component should re-render by returning something different than selected before (inspired byuseSelector
in react-redux)If you include the
equalityFn
function, you can choose how to compare yourselect
function's return value (again inspired byuseSelector
in react-redux)Implementation Approach
I've introduced 3 new options to the
useEditor
hook (and subsequently the editor provider).immediatelyRender
which is to control the new vs. the old behaviorselect
which is to give the consumer fine-grained control over rendering by selecting the values they care about in re-rendering the editorequalityFn
which defines how to compare the values that the consumer generates with theselect
functionWhen not specifying the
immediateRender
value, if it is detected to be in SSR mode (i.e. no window object) it will be assumed to befalse
to not break Next.js users (but printing a message that they should be explicit about this), otherwise it will be assumed to betrue
reducing flicker in existing applications.Eventually, when we have confidence to do so (i.e. the next major version) we can throw an error instead and have Next.js users (and other ssr frameworks) have to explicitly opt out for their use case (or perhaps a new hook).
Testing Done
I tested in the demos using all possible options and in a next application here is a table for reference:
Testing this sort of thing in react can be a little complicated (since you need to control when react re-renders) but if someone knows of a way to test this I'm happy to add tests for it.
Verification Steps
Run the demos and set different values for
immediatelyRender
and in a Next.js app.Additional Notes
I'm unsure what version tiptap claims to be compatible with, and I know older versions do not have
useSyncExternalStore
but I also know thatreact-redux
uses a shim to make it compatible with older versions.Checklist
feat: Implement new feature
orchore(deps): Update dependencies
)Related Issues
#5001