Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translucent line for visibility #12610

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

mucunwuxian
Copy link
Contributor

@mucunwuxian mucunwuxian commented Jan 11, 2024

Thank you πŸ™ for your contribution to Ultralytics πŸš€! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:

  1. Check for Existing Contributions: Before submitting, kindly explore existing PRs to ensure your contribution is unique and complementary.

-> I checked that there are no similar PRs.



  1. Link Related Issues: If your PR addresses an open issue, please link it in your submission. This helps us better understand the context and impact of your contribution.

-> I created an issue. #12612



  1. Elaborate Your Changes: Clearly articulate the purpose of your PR. Whether it's a bug fix or a new feature, a detailed description aids in a smoother integration process.

-> I added an argument to make the bounding box line translucent to improve visibility of results.
How about this?



  1. Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:

    I have read the CLA Document and I hereby sign the CLA

-> I have read the CLA Document and I hereby sign the CLA.



For more detailed guidance and best practices on contributing, refer to our βœ… Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

πŸ“Š Key Changes

  • Imported the numpy library to manipulate image data.
  • Added a new parameter line_alpha for bounding box transparency in the detect.py script.

🎯 Purpose & Impact

The purpose of introducing line_alpha is to enhance the visibility of detection results by making the bounding boxes translucent. This change can help users discern background details that might be important for context without compromising the visibility of the bounding box itself. The impact is improved visual analysis for the user, especially in situations where seeing the background information is just as critical as seeing the object detections.

🌟 Summary

Introducing πŸ”Ž translucent bounding boxes in Ultralytics' YOLOv5 for better visibility and context during object detection.

@glenn-jocher
Copy link
Member

@mucunwuxian hello! πŸ‘‹

Thank you so much for your kind words and for your contribution to the YOLOv5 project! It's fantastic to see community members like yourself getting involved. 😊

Regarding your PR for adding a translucent bounding box line argument, that sounds like a potentially useful feature for improving result visualization. Please make sure to detail the changes in your PR description, including any new argument options and how they affect the output. This will help us understand and review your contribution more effectively.

Don't forget to link any related issues as mentioned, and if you haven't already, please sign the CLA to move forward with the contribution process.

Looking forward to reviewing your PR, and once again, thanks for supporting the YOLOv5 community! πŸš€

@mucunwuxian
Copy link
Contributor Author

mucunwuxian commented Jan 11, 2024

@glenn-jocher
Hello!βœ‹βœ¨
Thank you for your reply!

I added comments.
How abount this?
Are there are any shortage?

@glenn-jocher
Copy link
Member

Hello @mucunwuxian! πŸ‘‹

Great to hear that you've added comments to your PR. πŸ‘

To ensure everything is in order, please double-check the following:

  • Your PR description should clearly explain the changes made and their impact on the codebase.
  • Make sure you've documented how to use the new translucent line feature, including any new argument syntax.
  • Ensure that your code changes are well-commented and follow the existing code style for consistency.
  • Verify that you've tested the new feature and it works as expected without introducing new bugs.

If all these points are covered and your PR is linked to the issue you created, there shouldn't be any shortage in your submission. Once everything looks good, we'll proceed with the review process.

Thank you for your diligence and for contributing to YOLOv5! 🌟

@mucunwuxian
Copy link
Contributor Author

@glenn-jocher
Thank you for your reply!

There are only a few code changes.
I think there is no problem.

It seems that the line break was added by the autocorrect function.
I hope you can adjust the appearance in any way you like.

I think it will be more intuitive and user-friendly!

@glenn-jocher
Copy link
Member

Hello again @mucunwuxian! πŸ˜„

It's great to hear that the code changes are minimal and you've considered the user experience. If the autocorrect function has introduced unintended line breaks, it's a good idea to review and clean up the formatting before finalizing the PR. Clean and readable code is always appreciated!

Once you've made sure the appearance and functionality align with your intentions, we'll be happy to review it. Your efforts to make YOLOv5 more intuitive and user-friendly are very much appreciated!

Looking forward to your PR, and thank you for being proactive in enhancing the project! 🌟

@mucunwuxian
Copy link
Contributor Author

@glenn-jocher
Thank you for your reply!

After arranging the appearance, I ran the automatic PR check again.πŸ‘
I hope you can check the contents.

@glenn-jocher
Copy link
Member

Hello @mucunwuxian,

Fantastic! Thank you for tidying up the appearance and rerunning the automatic checks. πŸ‘

I'll take a look at the contents of your PR as soon as possible. Your proactive approach is greatly appreciated, and it's contributors like you who help make YOLOv5 better for everyone.

Thanks again for your contribution! 🌟

@mucunwuxian
Copy link
Contributor Author

Hi, @glenn-jocher
Is there anything I can do for you?

@glenn-jocher
Copy link
Member

Hello @mucunwuxian,

Thank you for checking in! At this point, if you've ensured that your PR is complete with all necessary information and passes all checks, there's nothing more you need to do for now. I'll review your PR and get back to you with any feedback or if any further actions are required on your end.

Your patience and willingness to help are much appreciated! 😊 If you have any other questions or additional contributions, feel free to share them.

Have a great day!

Copy link
Contributor

github-actions bot commented Apr 9, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I sign the CLA


2 out of 3 committers have signed the CLA.
βœ… (UltralyticsAssistant)[https://github.com/UltralyticsAssistant]
βœ… (glenn-jocher)[https://github.com/glenn-jocher]
❌ @mucunwuxian
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants