New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the SPPF code slightly to run tiny bit faster #12830
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @chinya07, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with
ultralytics/yolov5
master
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify all YOLOv5 Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
@chinya07 thank you for the fantastic work on optimizing the SPPF layer! 🚀 Your contribution emphasizes the community's crucial role in enhancing YOLOv5's performance and evolving its capabilities. This optimization indeed paves the way for better feature extraction, flexibility, and versatility, allowing users to fine-tune the balance between computational efficiency and model complexity. We appreciate your efforts in making YOLOv5 even more adaptable and efficient for a wide range of applications. Your detailed summary and the thoughtful implementation of adjustable pooling levels and iterative pooling are great examples of the innovative spirit that drives our community forward. Let's keep pushing the boundaries of what's possible together! 🌟 |
@chinya07 all tests are failing in your PR, seems like your changes have created bugs. Review and fix all of the issues before we can consider this, thank you! |
I have read the CLA Document and I sign the CLA 2 out of 3 committers have signed the CLA. |
--> There is no open issue as this is just a small updation with the existing SPPF code to slightly enhance the execution speed of the module.
--> This is a try to slightly improve the overall execution speed of the SPPF module by streamlining the forward pass. This approach minimizes the amount of repeated code and may offer slight improvements in execution speed due to the looped pooling operations.
Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:
I have read the CLA Document and I hereby sign the CLA
--> I have read the CLA Document and I hereby sign the CLA
For more detailed guidance and best practices on contributing, refer to our ✅ Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.
--->
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Optimized Spatial Pyramid Pooling layer (SPPF) introduces an iterative pooling approach for enhanced feature extraction in YOLOv5.
📊 Key Changes
levels
parameter to customize the number of pooling levels.🎯 Purpose & Impact
levels
parameter), allowing for a balance between computational performance and model complexity.🚀 This optimization not only aims to bolster the YOLOv5 model's performance but also provides users with greater control over model architecture customization, paving the way for tailored applications in various domains.