New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DataLoader
related parameters to fit()
and predict()
#2295
base: master
Are you sure you want to change the base?
add DataLoader
related parameters to fit()
and predict()
#2295
Conversation
…predict()` of `TorchForecastingModel`
b1ec50c
to
3503b41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2295 +/- ##
==========================================
- Coverage 93.79% 93.77% -0.02%
==========================================
Files 138 138
Lines 14288 14274 -14
==========================================
- Hits 13401 13386 -15
- Misses 887 888 +1 ☔ View full report in Codecov by Sentry. |
Hi @BohdanBilonoh, It looks great, however to make it easier to maintain and more exhaustive, I think that it would be great to just add an argument called It will allow users to specify more than just PS: Apologies for taking so long with the review of this PR. |
Hi @BohdanBilonoh, Would you please add multiprocessing_context parameter for Dataloader, it is useful when we use multi-workers for dataloader, Thanks! |
@BohdanBilonoh refer to #2375 |
@BohdanBilonoh My bad, it is good idea from @madtoinou to add dataloader_kwargs to let user input dataloader parameters as wish freely, not need to support special multiprocessing_context parameter forcibly |
Checklist before merging this PR:
Summary
Add
torch.utils.data.DataLoader
related parameters tofit()
andpredict()
ofTorchForecastingModel