Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/min_train_samples and min_train_series_length are properly computed #2353

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

madtoinou
Copy link
Collaborator

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes fixes #2264, fixes #1823.

Summary

  • min_train_series_length and min_train_samples are now properly depending on each other
  • min_train_samples attribute was relaxed for models such as ARIMA or LinearRegression, it is now the value under which, the model raises an error
  • historical_forecasts() now rely on min_train_series_length to assess how many steps must be set aside when retrain=True and train_length=None.
  • added min_train_past_covariates_series_length and min_train_future_covariates_series_length attributes, they assume that the series are optimally aligned with the target

Other Information

  • added tests for the historical forecasts utils functions
  • improved parametrization of historical forecasts tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant