-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wpf): Fix IsLeftButtonPressed status on WPF platform #16517
fix(wpf): Fix IsLeftButtonPressed status on WPF platform #16517
Conversation
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16517/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lindexi 👍
Head branch was pushed to by a user without write access
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
63212b3
to
4591023
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Input/Pointers/PointerEventArgsTests.xaml.cs
Outdated
Show resolved
Hide resolved
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16517/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
GitHub Issue (If applicable): #14393
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We can receive the pointer event with IsLeftButtonPressed is true when touch release.
What is the new behavior?
We can receive the pointer event with IsLeftButtonPressed is false when touch release.
See https://github.com/unoplatform/uno/pull/16378/files#r1575262313
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Cc @dr1rrb , and I will add more information about the barel button and the eraser status later.
Internal Issue (If applicable):