feat: persist last opened env per collection #2238
Open
+97
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoferreiralima
commented
May 4, 2024
| @@ -101,7 +101,7 @@ const addEnvironmentFile = async (win, pathname, collectionUid, collectionPath) | |||
|
|
|||
| file.data = bruToEnvJson(bruContent); | |||
| file.data.name = basename.substring(0, basename.length - 4); | |||
| file.data.uid = getRequestUid(pathname); | |||
| file.data.uid = generateUidBasedOnHash(pathname); | |||
There was a problem hiding this comment.
this is needed! otherwhise the env wil have a different uid every startup.
The env files dont are moved without move the collection so the problem solved with requestUid dont apply for envs
Thanks! |
|
It's duplicated with the PR already waiting to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #112
Description
This PR add the feature of save the last env that was opened for a collection.
Contribution Checklist: