Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bru electron: bump to version that supports node_extra_ca_certs #2258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

logandavies181
Copy link

@logandavies181 logandavies181 commented May 7, 2024

Description

Closes #2257. As it turns out, Electron finally added support for this under version v30.0.0 馃殌

Electron feature req: electron/electron#41590
Original PR: electron/electron#41689
Backport for v30: electron/electron#41822

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@busy-panda
Copy link
Contributor

@logandavies181 Have you tested if everything works with the latest version of electron ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NODE_EXTRA_CA_CERTS
2 participants