Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client info traffic stat fields. #45

Merged
merged 4 commits into from May 6, 2024

Conversation

CharlesChen888
Copy link
Member

@CharlesChen888 CharlesChen888 commented Apr 23, 2024

Corresponding doc PR to valkey-io/valkey#327.

  • tot-net-in: Total network input bytes read from this client. Added in Valkey 8.0
  • tot-net-out: Total network output bytes sent to this client. Added in Valkey 8.0
  • tot-cmds: Total count of commands this client executed. Added in Valkey 8.0

Signed-off-by: Chen Tianjie <TJ_Chen@outlook.com>
Copy link

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split this into two PRs.

commands/client-list.md Show resolved Hide resolved
@madolson
Copy link
Member

Change LGTM, but agree with stockholmux.

@zuiderkwast zuiderkwast added the waiting-for-upstream Docs for features not yet merged label Apr 23, 2024
Signed-off-by: Chen Tianjie <TJ_Chen@outlook.com>
@CharlesChen888 CharlesChen888 changed the title Add client info lib info and traffic stat fields. Add client info traffic stat fields. Apr 24, 2024
@CharlesChen888
Copy link
Member Author

lib-name and lib-version are now separated to #57.

@madolson madolson merged commit 569152c into valkey-io:main May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-upstream Docs for features not yet merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants