Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default pidfile #321

Open
Tracked by #25
zuiderkwast opened this issue Apr 15, 2024 · 0 comments · May be fixed by #330
Open
Tracked by #25

Change default pidfile #321

zuiderkwast opened this issue Apr 15, 2024 · 0 comments · May be fixed by #330
Labels
breaking-change Indicates a possible backwards incompatible change rebranding Valkey is not Redis release-notes This issue should get a line item in the release notes

Comments

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Apr 15, 2024 •
edited

The default pidfile is controlled by this define:

server.h:#define CONFIG_DEFAULT_PID_FILE "/var/run/redis.pid"

The comment in valkey.conf (describing what the default is) needs to match that.

Changing it to valkey.pid is a breaking change, so we'll do it in the next major version.
@zuiderkwast zuiderkwast mentioned this issue Apr 15, 2024
Open
18 tasks
@zuiderkwast zuiderkwast added release-notes This issue should get a line item in the release notes rebranding Valkey is not Redis breaking-change Indicates a possible backwards incompatible change labels Apr 15, 2024
@zuiderkwast zuiderkwast mentioned this issue Apr 15, 2024
Merged
@0del 0del linked a pull request Apr 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Indicates a possible backwards incompatible change rebranding Valkey is not Redis release-notes This issue should get a line item in the release notes
Projects
Valkey 8.0
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draft: rename redis.pid to valkey.pid 0del/valkey
1 participant
@zuiderkwast