Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url links in valkey.conf #320

Merged
merged 2 commits into from Apr 15, 2024
Merged

Conversation

PingXie
Copy link
Member

@PingXie PingXie commented Apr 15, 2024

No description provided.

Signed-off-by: Ping Xie <pingxie@google.com>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the non-URL.

valkey.conf Outdated Show resolved Hide resolved
valkey.conf Outdated Show resolved Hide resolved
@madolson
Copy link
Member

I keep forgetting if I push a commit I have to add the DCO :/

Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
@madolson madolson dismissed zuiderkwast’s stale review April 15, 2024 17:49

It's been resolved

@madolson madolson merged commit 2ec8f63 into valkey-io:unstable Apr 15, 2024
14 checks passed
@PingXie PingXie deleted the valkey-conf branch April 15, 2024 18:19
madolson added a commit that referenced this pull request Apr 15, 2024
Signed-off-by: Ping Xie <pingxie@google.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
zuiderkwast pushed a commit to zuiderkwast/placeholderkv that referenced this pull request Apr 17, 2024
Signed-off-by: Ping Xie <pingxie@google.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
@Katherine199119

This comment was marked as abuse.

PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this pull request Apr 24, 2024
Signed-off-by: Ping Xie <pingxie@google.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants