Update oom_score_adjusted_by_redis to oom_score_adjusted_by_valkey in server.c #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivshankar-Reddy
force-pushed
the
server-c-comments
branch
from
57adc7f
to
6524a71
Compare
CharlesChen888
approved these changes
Apr 11, 2024
|
@zuiderkwast Can you review this when you have sometime? |
zuiderkwast
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Thanks!
All seems good, but I want to separate into separate PRs, for various reasons. That's why it was separated in #25 into separate categories.
- internals (variable names and comments)
- log messages
- other output like usage
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Shivshankar-Reddy
force-pushed
the
server-c-comments
branch
from
adca51a
to
632e0f0
Compare
Shivshankar-Reddy
changed the title
enjoy-binbin
approved these changes
Apr 18, 2024
enjoy-binbin
changed the title
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
… server.c (valkey-io#229) Update oom_score_adjusted_by_redis to oom_score_adjusted_by_valkey in server.c Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update oom_score_adjusted_by_redis to oom_score_adjusted_by_valkey in server.c