Rename macros in config.h. #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
|
@hwware @zuiderkwast Part of #25 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #257 +/- ##
============================================
- Coverage 68.40% 68.33% -0.08%
============================================
Files 108 108
Lines 61562 61562
============================================
- Hits 42111 42066 -45
- Misses 19451 19496 +45
|
Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
zuiderkwast
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
We discussed earlier that it's better to make functions brand neutral, like using server_ prefix instead of valkey_, but server_fsync would be a bit non-unique maybe. I don't mind that we keep valkey here for now.
Can you update the top comment to list all the names you search-replaced using regex? (If it's not too much...) [Edit] I edited the top comment a little and used it as the commit message when merging.
Thanks!
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
This patch try to do following things: 1. Rename `redis_*` and `REDIS_*` macros defined in config.h to `valkey_*`, `VALKEY_*` and update associated used files. (`redis_fstat`, `redis_fsync`, `REDIS_THREAD_STACK_SIZE`, etc.) 2. Remove the leading double underscore for guard macro in config.h. --------- Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch try to do following things:
redis_*andREDIS_*macros defined in config.h tovalkey_*,VALKEY_*and update associated used files. (redis_fstat,redis_fsync,REDIS_THREAD_STACK_SIZE, etc.)